[CURA-9178] Port external Voronoi fixes #1731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of the externally contributed Voronoi fixes/workarounds. Boost-Voronoi doesn't always correctly generate the Voronoi we need. One of the problems is that a vertex we know should be there (from the polygon) can be missing. As the possibility of fixing it within Boost (or even another Voronoi solution or library) seems distant, if we detect a case like this, we rotate the model and try again. (This also forms the basis for at least one other workaround. -- See next commit in this PR probably.) Co-authored-by: Lukáš Hejl <[email protected]>
Second of the externally contributed Voronoi fixes/workarounds. Boost-Voronoi doesn't always correctly generate the Voronoi we need. The bigger of the (at least two) problems is that the Voronoi-diagram can intersect itself in strange ways (AKA be 'non-planar' in graph-theoretical terms). As the possibility of fixing it within Boost (or even another Voronoi solution or library) seems distant, if we detect a case like this, we rotate the model and try again. (This is based on the basework laid in the previous commit.) Co-authored-by: Lukáš Hejl <[email protected]>
Reported externally by others using the Arachne code in their engine. Not checked if this actually happens in CuraEngine yet as well, but can't hurt as it shouldn't alter the outcome if already correct. Co-authored-by: Lukáš Hejl <[email protected]>
Reported externally by others using the Arachne code in their engine. Not checked if this actually happens in CuraEngine yet as well, but seems plausible, and it's only an epsilon otherwise. Co-authored-by: Lukáš Hejl <[email protected]>
Purely deensive programming, as CuraEngine (probably) doesn't use large enough scales for this to _actually_ trip up the boost voronoi generation, yet. But it helps to be prepared. Co-authored-by: Lukáš Hejl <[email protected]>
|
This looks very interesting as a solution for this long standing issue! However I can't slice simple models with it. After |
Piezoid
reviewed
Sep 13, 2022
Otherwise dangling references result in vertex_mapping and/or segments, since those can refer to the vertices in the polygon copy.
Piezoid
reviewed
Sep 13, 2022
Co-authored-by: Maël Kerbiriou <[email protected]>
This reverts commit 4593f67.
2 tasks
|
This never worked properly for us, and we've got a completely different workaround by using the Wagyu library to fix our polygons instead. (See: #2030 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workarounds and fixes for certain Arachne foibles. Mostly to do with crashes due to improper Voronoi generation by Boost (or pre-processing necessary for that).
See individual commit messages for greater explanation.
We received a mail from someone that pointed us to these extant fixes. Would be a shame if we didn't incorporate them ;-)
--> Currently in draft, as it only compiles, not tested yet at all!
--> Also there are some problems, see the discussion(s) below. My attempt(s) to fix these went beyond a port (but are simplified as well in way) and can be found in the
CURA-9178_temp_sidebranch.